Re: [PATCH RESEND] media: i2c: isl7998x: inline i2c_check_functionality check

[Michael Tretter]

On Sun, 17 May 2026 19:20:35 +0200, Thorsten Blum wrote:
> Inline the i2c_check_functionality() check, since the function returns a
> boolean status rather than an error code.

Actually, i2c_check_functionality() returns the boolean result of the
comparison as an int. It's better to treat it like a boolean, though.

> 
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>

Reviewed-by: Michael Tretter <m.tretter@xxxxxxxxxxxxxx>

> ---
>  drivers/media/i2c/isl7998x.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/isl7998x.c b/drivers/media/i2c/isl7998x.c
> index 5ffd53e005ee..96702c5eaa35 100644
> --- a/drivers/media/i2c/isl7998x.c
> +++ b/drivers/media/i2c/isl7998x.c
> @@ -1460,8 +1460,7 @@ static int isl7998x_probe(struct i2c_client *client)
>  	int nr_inputs;
>  	int ret;
>  
> -	ret = i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA);
> -	if (!ret) {
> +	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA)) {
>  		dev_warn(&adapter->dev,
>  			 "I2C-Adapter doesn't support I2C_FUNC_SMBUS_WORD\n");
>  		return -EIO;
>