[PATCH 3/8] drm/bridge: dw-hdmi-qp: Use the common TMDS char rate constant

From: Javier Martinez Canillas

Date: Tue May 19 2026 - 10:56:55 EST


Replace the driver local HDMI14_MAX_TMDSCLK define with the shared
constant defined in the <drm/display/drm_hdmi_helper.h> header.

The local define incorrectly referenced HDMI 1.4, but the 340 MHz
maximum TMDS character rate was actually introduced in HDMI 1.3.

Suggested-by: Maxime Ripard <mripard@xxxxxxxxxx>
Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
---

drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
index 0dbb12743609..37d8292b6f7f 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
@@ -38,8 +38,6 @@
#define DDC_CI_ADDR 0x37
#define DDC_SEGMENT_ADDR 0x30

-#define HDMI14_MAX_TMDSCLK 340000000
-
#define SCRAMB_POLL_DELAY_MS 3000

/*
@@ -835,9 +833,9 @@ dw_hdmi_qp_bridge_tmds_char_rate_valid(const struct drm_bridge *bridge,
/*
* TODO: when hdmi->no_hpd is 1 we must not support modes that
* require scrambling, including every mode with a clock above
- * HDMI14_MAX_TMDSCLK.
+ * DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3.
*/
- if (rate > HDMI14_MAX_TMDSCLK) {
+ if (rate > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3) {
dev_dbg(hdmi->dev, "Unsupported TMDS char rate: %lld\n", rate);
return MODE_CLOCK_HIGH;
}
--
2.54.0