Re: [PATCH v1] mctp: i2c: Use named initializers for struct i2c_device_id

[Jeremy Kerr]

Hi Uwe,

> While being less compact,

oh no! :D

> using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
> 
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits. The former was confirmed with x86 and arm64
> builds.
> 
> While touching this array, unify usage of whitespace in the list
> terminator to what most other arrays are using.

Looks good, thanks. The overall i2c_device_id plan makes sense.

Acked-by: Jeremy Kerr <jk@xxxxxxxxxxxxxxxxxxxx>

Cheers,


Jeremy