Re: [PATCH v3 04/12] x86,fs/resctrl: Program PLZA through kmode arch hooks

[Luck, Tony]

On Thu, Apr 30, 2026 at 06:24:49PM -0500, Babu Moger wrote:
> +void resctrl_arch_configure_kmode(cpumask_var_t cpu_mask, u32 closid, u32 rmid, bool enable)
> +{
> +	union msr_pqr_plza_assoc plza = { 0 };
> +
> +	plza.split.rmid = rmid;
> +	plza.split.rmid_en = 1;

Shouldn't there be a parameter for the value of rmid_en?

User asked for global_assign_ctrl_assign_mon_per_cpu set it to '1'

User asked for global_assign_ctrl_inherit_mon_per_cpu set it to '0'

> +	plza.split.closid = closid;
> +	plza.split.closid_en = 1;
> +	plza.split.plza_en = enable;
> +
> +	on_each_cpu_mask(cpu_mask, resctrl_kmode_set_one_amd, &plza, 1);
> +}

-Tony