Re: [PATCH] crypto: hisilicon/sec2 - lower priority for hisilicon crypto implementations

[Eric Biggers]

On Wed, May 20, 2026 at 09:22:49AM +0800, liulongfang wrote:
> On 2026/5/11 8:49, Chenghai Huang wrote:
> > From: lizhi <lizhi206@xxxxxxxxxx>
> > 
> > Lower the priority of HiSilicon's crypto implementations to allow more
> > suitable alternatives to be selected. For example, certain kernel
> > use-cases do not benefit from HiSilicon's symmetric crypto algorithms.
> > This change ensures that more appropriate options are chosen first while
> > retaining HiSilicon's implementations as alternatives.
> > 
> > Signed-off-by: lizhi <lizhi206@xxxxxxxxxx>
> > Signed-off-by: Chenghai Huang <huangchenghai2@xxxxxxxxxx>
> > ---
> >  drivers/crypto/hisilicon/sec2/sec_crypto.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.c b/drivers/crypto/hisilicon/sec2/sec_crypto.c
> > index 2471a4dd0b50..77e0e03cbcab 100644
> > --- a/drivers/crypto/hisilicon/sec2/sec_crypto.c
> > +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.c
> > @@ -20,7 +20,7 @@
> >  #include "sec.h"
> >  #include "sec_crypto.h"
> >  
> > -#define SEC_PRIORITY		4001
> > +#define SEC_PRIORITY		80
> >  #define SEC_XTS_MIN_KEY_SIZE	(2 * AES_MIN_KEY_SIZE)
> >  #define SEC_XTS_MID_KEY_SIZE	(3 * AES_MIN_KEY_SIZE)
> >  #define SEC_XTS_MAX_KEY_SIZE	(2 * AES_MAX_KEY_SIZE)
> > 
> 
> Reviewed-by: Longfang Liu <liulongfang@xxxxxxxxxx>

Makes sense, but perhaps this driver should just be removed entirely?

- Eric