Re: [PATCH] hwmon: (coretemp) Replace sprintf() with sysfs_emit() for sysfs show functions

[Guenter Roeck]

On 5/19/26 19:14, Dongyang Jin wrote:
> You are absolutely right, and I apologize for the noise.
> I misunderstood the scope of acceptable cleanups for legacy drivers. I will stop sending such patches and focus only on functional fixes or updates for drivers that specifically require them.

Times change. Until recently there was no AI code review, and it was unknown
that the code is in such a bad shape. We have to concentrate on fixing bugs
for the time being.

On top of that, it does appear that people started using AI to implement changes
such as this one, even though many of such changes could be implemented with
a deterministic application such as Coccinelle. That adds additional burden
on reviewers. While AI is good at finding bugs, its ability for fixing them
isn't that good. Result is that those cleanups can not be trusted, meaning
they require extra scrutiny. I just do not have the time for that right now.

Thanks,
Guenter

> Thank you for your time.
> Best regards,
> Dongyang Jin
>
> On 2026/5/19 23:16, Guenter Roeck wrote:
> > On 5/18/26 23:52, Dongyang Jin wrote:
> > > Replace sprintf() with sysfs_emit() in sysfs show functions.  sysfs_emit()
> > > is preferred for formatting sysfs output because it provides safer bounds
> > > checking.  No functional changes.
> > >
> > > Signed-off-by: Dongyang Jin <jindongyang@xxxxxxxxxx>
> >
> > I consider this a nuisance patch. Nothing is gained from it.
> > Can people please stop sending such patches ? It gets annoying,
> > and I don't have an endless amount of time to review it all.
> >
> > If you make a functional change or fix bugs, cleanups are welcome.
> > Otherwise, I'll barely accept bare cleanup patches for drivers
> > using the with_info API. Otherwise please leave old drivers alone.
> >
> > Thanks,
> > Guenter