Re: [PATCH net-next v2 1/8] net: dsa: microchip: don't reset on shutdown or driver removal

From: Bastien Curutchet

Date: Wed May 20 2026 - 02:23:49 EST


Hi Jakub,

On 5/20/26 4:10 AM, Jakub Kicinski wrote:
On Fri, 15 May 2026 10:38:36 +0200 Bastien Curutchet wrote:
@@ -4170,16 +4170,15 @@ int ksz_set_wol(struct dsa_switch *ds, int port,
* the wol_enabled flag accordingly to reflect whether WoL is active on any
* port.
*/
-static void ksz_wol_pre_shutdown(struct ksz_device *dev, bool *wol_enabled)
+static void ksz_wol_pre_shutdown(struct ksz_device *dev)

this needs a kdoc update, did I not report it on v1?
Maybe I forgot. scripts/kernel-doc is buggy, unfortunately
and doesn't catch it. The fix is on the way.

Ok, I'll fix it in v3. I don't think that you reported it on v1.


Best regards,
Bastien