Re: [PATCH v5 0/5] KSM: performance optimizations for rmap_walk_ksm

From: xu.xin16

Date: Wed May 20 2026 - 02:40:52 EST


> > Changes in v5:
> > - Patch 1: replaced local_clock() with tracepoints – no overhead
> > when tracepoints are disabled.
>
> Thanks for that change.
>
> > - Patch 3: switched from vm_pgoff (unstable after VMA split) to a
> > linear page offset.
> > - Patch 4: adapted to the linear page offset; added user-impact
> > description (real workloads, lock contention examples,
> > VMA splitting scenario).
> > - Patch 5: simplified to a single process with 32 pages (instead
> > of multi-process), as suggested by David.
> >
> > MAINTAINERS | 3 +
>
> I don't recall seeing any discussion about you becoming an rmap
> M:aintainer, perhaps I missed it. Thanks for the interest, but it
> probably would be better to propose this as a standalone patch,
> separated from this series.
>

You are absolutely right – I did not discuss this change on the mailing
list beforehand and I agree that a MAINTAINERS update should be a
separate, standalone patch.

My intention was to help review future changes to the
rmap benchmark and tracepoints, but you are right that it needs its
own discussion. Thanks for the reminder.

My hope was that for future changes
touching these specific rmap test files or the rmap tracepoints,
maintainers or other developers could cc me so that I can help review
or test them. By the way , I was Adding myself as an R: (reviewer) rather
than M: