Re: [PATCH v3 2/8] dt-bindings: extcon: qcom,pm8941-misc: Add PM8921 compatible

[Krzysztof Kozlowski]

On 19/05/2026 09:16, Alexandre MINETTE via B4 Relay wrote:
> From: Alexandre MINETTE <contact@xxxxxxxxxxx>
> 
> PM8921/PM8821 provide USB ID detection through the PMIC USB block. The
> USB_ID_IN interrupt is exposed by the PM8921 interrupt controller and is
> used by APQ8064 platforms for OTG role detection.
> 
> The device is modeled as a child of the SSBI-connected PM8921 PMIC.
> Unlike PM8941, the downstream PM8xxx misc device is not instantiated with
> a register resource for this path, and the mainline extcon driver only

I could have guessed that at v2, but this suggests that device is not a
separate block. If it does not have separate addressing, then it is not
a dedicated/separate sub device in the PMIC and your node plus binding
should be squashed into the parent.

> needs the named USB ID interrupt. Allow qcom,pm8921-misc without requiring
> reg.
> 
> Signed-off-by: Alexandre MINETTE <contact@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/extcon/qcom,pm8941-misc.yaml    | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)


Best regards,
Krzysztof