Re: [PATCH] irqchip/dw-apb-ictl: fix compilation on x86
From: Thomas Gleixner
Date: Wed May 20 2026 - 05:02:13 EST
On Tue, May 19 2026 at 14:22, Rosen Penev wrote:
> On Tue, May 19, 2026 at 10:16 AM Thomas Gleixner <tglx@xxxxxxxxxx> wrote:
>>
>> On Mon, May 18 2026 at 19:57, Rosen Penev wrote:
>> > __irq_entry belongs nowhere in irqchip drivers as it is an
>> > architecture specific annotation. There's no specific architecture
>> > depends for DW_APB_ICTL and there probably shouldn't be.
>>
>> Care to see how that driver is selected? Certainly not by x86.
> make LLVM=1 ARCH=i386 allmodconfig
> make LLVM=1 ARCH=i386 -j 31
How does that select the config symbol?
Makefile:
obj-$(CONFIG_DW_APB_ICTL) += irq-dw-apb-ictl.o
Kconfig:
config DW_APB_ICTL
bool
select GENERIC_IRQ_CHIP
select IRQ_DOMAIN_HIERARCHY
# git grep DW_APB_ICTL
arch/arc/plat-axs10x/Kconfig: select DW_APB_ICTL
arch/arm/mach-berlin/Kconfig: select DW_APB_ICTL
arch/arm/mach-hisi/Kconfig: select DW_APB_ICTL
arch/arm64/Kconfig.platforms: select DW_APB_ICTL
arch/csky/Kconfig.platforms: select DW_APB_ICTL
i386 definitely does not select it.
# grep DW_APB_ICTL ../build-386/.config
#