Re: [PATCH v4 13/39] drm/msm/dp: introduce stream_id for each DP panel

[Yongxing Mou]

On 4/12/2026 8:04 AM, Dmitry Baryshkov wrote:
> On Fri, Apr 10, 2026 at 05:33:48PM +0800, Yongxing Mou wrote:
> > From: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> >
> > With MST, each DP controller can handle multiple streams.
> > There shall be one dp_panel for each stream but the dp_display
> > object shall be shared among them. To represent this abstraction,
> > create a stream_id for each DP panel which shall be set by the
> > MST stream. For SST, default this to stream 0.
> >
> > Use the stream ID to control the pixel clock of that respective
> > stream by extending the clock handles and state tracking of the
> > DP pixel clock to an array of max supported streams. The maximum
> > streams currently is 4.
> >
> > Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> > Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/msm/dp/dp_ctrl.c    | 57 +++++++++++++++++++++++--------------
> >   drivers/gpu/drm/msm/dp/dp_ctrl.h    |  2 +-
> >   drivers/gpu/drm/msm/dp/dp_display.c | 24 ++++++++++++++--
> >   drivers/gpu/drm/msm/dp/dp_display.h |  2 ++
> >   drivers/gpu/drm/msm/dp/dp_panel.h   | 11 +++++++
> >   5 files changed, 71 insertions(+), 25 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
> > index 120ec00884e5..fb6396727628 100644
> > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c
> > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c
> > @@ -127,7 +127,7 @@ struct msm_dp_ctrl_private {
> >   	unsigned int num_link_clks;
> >   	struct clk_bulk_data *link_clks;
> >   
> > -	struct clk *pixel_clk;
> > +	struct clk *pixel_clk[DP_STREAM_MAX];
> >   
> >   	union phy_configure_opts phy_opts;
> >   
> > @@ -139,7 +139,7 @@ struct msm_dp_ctrl_private {
> >   
> >   	bool core_clks_on;
> >   	bool link_clks_on;
> > -	bool stream_clks_on;
> > +	bool stream_clks_on[DP_STREAM_MAX];
>
> drivers/gpu/drm/msm/dp/dp_ctrl.c: In function ‘msm_dp_ctrl_core_clk_enable’:
> drivers/gpu/drm/msm/dp/dp_ctrl.c:1937:9: warning: the comparison will always evaluate as ‘true’ for the address of ‘stream_clks_on’ will never be NULL [-Waddress]
>   1937 |         drm_dbg_dp(ctrl->drm_dev, "stream_clks:%s link_clks:%s core_clks:%s\n",
>        |         ^~~~~~~~~~
Emm. thanks will fix this next vesion.