Re: [PATCH] PCI: rcar-host: Remove unused LIST_HEAD(res)

[Geert Uytterhoeven]

Hi Prabhakar,

On Wed, 20 May 2026 at 11:11, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Remove the unused LIST_HEAD(res) declaration from
> rcar_pcie_hw_enable().
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/pci/controller/pcie-rcar-host.c
> +++ b/drivers/pci/controller/pcie-rcar-host.c
> @@ -346,7 +346,6 @@ static void rcar_pcie_hw_enable(struct rcar_pcie_host *host)
>         struct rcar_pcie *pcie = &host->pcie;
>         struct pci_host_bridge *bridge = pci_host_bridge_from_priv(host);
>         struct resource_entry *win;
> -       LIST_HEAD(res);
>         int i = 0;
>
>         /* Try setting 5 GT/s link speed */

Indeed, this was never used since its introduction in commit
ce351636c67f75a9 ("PCI: rcar: Add suspend/resume").

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Since this does not seem to cause a warning, even with W=2 (TBH,
I had expected some shadowing warning), no Fixes-tag is needed?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds