Re: [PATCH v2 1/3] dt-bindings: iio: dac: Add AD5529R

[Jonathan Cameron]

On Tue, 19 May 2026 09:13:24 +0200
Janani Sunil <jan.sun97@xxxxxxxxx> wrote:

> On 5/16/26 21:25, David Lechner wrote:
> > On 5/8/26 7:48 AM, Jonathan Cameron wrote:  
> >> On Fri, 8 May 2026 13:55:47 +0200
> >> Janani Sunil <janani.sunil@xxxxxxxxxx> wrote:
> >>  
> >>> Devicetree bindings for AD5529R 16 channel 12/16 bit high voltage,
> >>> buffered voltage output digital-to-analog converter (DAC) with an
> >>> integrated precision reference.
> >>>
> >>> Signed-off-by: Janani Sunil <janani.sunil@xxxxxxxxxx>
> >>> ---  
> > ...
> >  
> >>> +  * Multiplexer for output voltage, load current sense and die temperature
> >>> +
> >>> +  Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad5529r.pdf
> >>> +
> >>> +properties:
> >>> +  compatible:
> >>> +    const: adi,ad5529r
> >>> +
> >>> +  reg:
> >>> +    maxItems: 1
> >>> +
> >>> +  spi-max-frequency:
> >>> +    maximum: 50000000
> >>> +
> >>> +  reset-gpios:
> >>> +    maxItems: 1
> >>> +    description:
> >>> +      GPIO connected to the RESET pin. Active low. When asserted low,
> >>> +      performs a power-on reset and initializes the device to its default state.
> >>> +
> >>> +  vdd-supply:
> >>> +    description: Digital power supply (typically 3.3V)
> >>> +
> >>> +  avdd-supply:
> >>> +    description: Analog power supply (typically 5V)
> >>> +
> >>> +  hvdd-supply:
> >>> +    description: High voltage positive supply (up to 40V for output range)
> >>> +
> >>> +  hvss-supply:
> >>> +    description: High voltage negative supply (ground or negative voltage)  
> >> I don't mind doing it this way but in some similar cases where 0 is something that
> >> can be considered the 'default' we've made the supply optional.  What was
> >> your reasoning for requiring it in this case?
> >>
> >> dt-bindings should be as complete as we can make them - with that in mind...
> >>
> >> There are some more interesting corners on this device the binding doesn't
> >> currently cover such as mux_out pin.  We'd normally do that by making the
> >> driver potentially a client of an ADC
> >>
> >> Easier though is !alarm which smells like an interrupt.
> >> !clear probably a gpio. TG0-3 also GPIOs.  
> > also optional vref-supply for external vs internal reference  
> 
> I will add bindings for optional Vref supply in the next version.
> 
> Best Regards,
> Janani Sunil
Hi Janil

One of those process things.  Don't reply to a review to say you
are going to do something suggested - just save us all reading an email
by making that clear in the change log for the next version.

Lots of folk are over enthusiastic in replying like you have done initially.
They only begin to appreciate why this is a bad idea when they start trying
to keep up with the mailing list firehoses!

Jonathan

>