Re: [PATCH 1/2] dt-bindings: regulator: mps,mp8899: Add binding for MP8899 PMIC

[Krzysztof Kozlowski]

On Tue, May 19, 2026 at 11:51:05PM +0530, Vignesh Viswanathan wrote:
> Add devicetree binding documentation for the Monolithic Power Systems
> MP8899 PMIC, which provides four synchronous buck converters controlled
> over I2C.

Please use subject prefixes matching the subsystem. You can get them for
example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> 
> Signed-off-by: Vignesh Viswanathan <vignesh.viswanathan@xxxxxxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/regulator/mps,mp8899.yaml  | 66 ++++++++++++++++++++++
>  1 file changed, 66 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/mps,mp8899.yaml b/Documentation/devicetree/bindings/regulator/mps,mp8899.yaml
> new file mode 100644
> index 000000000000..3225c92db2c8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mps,mp8899.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mps,mp8899.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Monolithic Power System MP8899 PMIC
> +
> +maintainers:
> +  - Vignesh Viswanathan <vignesh.viswanathan@xxxxxxxxxxxxxxxx>
> +
> +properties:
> +  $nodename:
> +    pattern: "^pmic@[0-9a-f]{1,2}$"

Drop nodename.

> +  compatible:
> +    enum:
> +      - mps,mp8899
> +
> +  reg:
> +    maxItems: 1
> +
> +  regulators:
> +    type: object
> +
> +    description: |

Do not need '|' unless you need to preserve formatting.

> +      list of regulators provided by this controller, must be named
> +      after their hardware counterparts BUCK[1-4]

Drop description.

> +
> +    patternProperties:
> +      "^buck[1-4]$":
> +        type: object
> +        $ref: regulator.yaml#
> +

Droip blank line

> +        unevaluatedProperties: false
> +
> +    additionalProperties: false

Put this additionalProps after type.

> +
> +required:
> +  - compatible
> +  - reg
> +  - regulators

Best regards,
Krzysztof