Re: [PATCH 3/3] usb: ucsi: ccg: Add support for CYPD6129 (CCG6)

From: Krzysztof Kozlowski

Date: Wed May 20 2026 - 07:54:00 EST


On 20/05/2026 11:37, Akash Kumar wrote:
> Add "cypress,cypd6129" to the UCSI CCG driver match table so the driver
> can bind to CCG6-based platforms using this controller.
>
> This is required for monza SOM USB-C support.

Pointless statement. What is "monza SOM"? Who could guess it in open
source community?

>
> Signed-off-by: Akash Kumar <akash.kumar@xxxxxxxxxxxxxxxx>
> ---
> drivers/usb/typec/ucsi/ucsi_ccg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c
> index 199799b319c2..0695ce348135 100644
> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c
> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c
> @@ -1520,6 +1520,7 @@ static void ucsi_ccg_remove(struct i2c_client *client)
>
> static const struct of_device_id ucsi_ccg_of_match_table[] = {
> { .compatible = "cypress,cypd4226", },
> + { .compatible = "cypress,cypd6129", },

NAK. You just said they are compatible!

Best regards,
Krzysztof