Re: [PATCH] gpu: host1x: trace: fix string fields in host1x traces
From: Thierry Reding
Date: Wed May 20 2026 - 08:16:04 EST
On Tue, May 19, 2026 at 02:10:59PM -0400, Steven Rostedt wrote:
> On Tue, 19 May 2026 12:16:43 +0200
> Artur Kowalski <arturkow2000@xxxxxxxxx> wrote:
>
> > Use __assign_str and __get_str as required by tracing subsystem. Fixes
> > string fields being rejected by the verifier and unreadable from
> > userspace.
>
> Does anyone use these tracepoints? The fact that they have been broken
> for 5 years and nobody noticed makes me think they are useless.
>
> I rather remove them than fix them, but if someone thinks that these
> are still useful then by all means apply this patch.
>
> Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
I know that Mikko used them a lot early on, but this driver is pretty
mature now, so we rarely need this low level of tracing. I'll defer to
Mikko on whether we still need these.
Thierry
Attachment:
signature.asc
Description: PGP signature