Re: [PATCH v2 1/8] video/hdmi: Add common TMDS character rate constants

[Dmitry Baryshkov]

On Wed, May 20, 2026 at 04:43:37PM +0200, Javier Martinez Canillas wrote:
> Several DRM drivers already define their own constants for minimum and
> maximum TMDS character rates.
> 
> By defining common rate constants in a shared header, drivers can just use
> them instead of having driver local define macros or use magic numbers.
> 
> The values defined in the <linux/hdmi.h> header correspond to maximum TMDS
> character rates defined by each HDMI specification version:
> 
>   - HDMI_TMDS_CHAR_RATE_MIN_HZ:     25 MHz (minimum for all versions)
>   - HDMI_1_0_TMDS_CHAR_RATE_MAX_HZ: 165 MHz (HDMI 1.0 maximum)
>   - HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ: 340 MHz (HDMI 1.3 maximum)
>   - HDMI_2_0_TMDS_CHAR_RATE_MAX_HZ: 600 MHz (HDMI 2.0 maximum)
> 
> Suggested-by: Maxime Ripard <mripard@xxxxxxxxxx>
> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
> ---
> 
> Changes in v2:
> - Change naming convention to HDMI_$SPEC_TMDS_CHAR_RATE_MAX_HZ (Maxime).
> - Define the constants in <linux/hdmi.h> (Dmitry).
> 
>  include/linux/hdmi.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>


-- 
With best wishes
Dmitry