Re: [PATCH 0/6] usb: typec: add Qualcomm PMI8998 USB Type-C role-switch support

[Dmitry Baryshkov]

On Tue, May 19, 2026 at 12:43:13AM +0100, Bryan O'Donoghue wrote:
> On 19/05/2026 00:37, Максим Фурман wrote:
> > Three shapes for adding a second port handler to the existing driver:
> >    (a) extracted ops -- pmic_typec_port_ops with chip-specific get_cc /
> >        get_vbus / set_mode / set_vconn / start_toggling, refactor PM8150B
> >        code into the ops, add parallel PMI8998 implementation
> >    (b) parallel port file -- keep PM8150B code untouched, add a sibling
> >        source file with the same tcpc_dev callback surface

2c, my preference would be this option.

> >    (c) per-chip register table + per-chip decode helpers in the same file
> > 
> > Bryan, do you have a preference? I'd rather match your taste than guess,
> > since you'll be maintaining the merged result.
> 
> Taste - loaded with honey, chilli and salt please chef and add the whole
> clove of garlic....
> 
> My feeling is sibling file but please use your own taste/discretion.
> 
> ---
> bod

-- 
With best wishes
Dmitry