Re: [RFC PATCH 0/2] Add driver for TI BQ25630 charger

[Waqar Hameed]

On Fri, Feb 27, 2026 at 16:35 +0100 Waqar Hameed <waqar.hameed@xxxxxxxx> wrote:

> This patch series contains a fully working driver for the basic
> functionality for the new TI BQ25630 charger (see datasheet [1]).
> However, some functionality has no straightforward implementation. The
> following features have therefore been left out and hopefully we can
> have some design discussions to reach a clear resolution for the next
> patch version (hence the RFC tag):
>
>   1. The USB OTG functionality (i.e. power *out* from the device) would
>      probably need a minor refactorization to use the MFD sub-system to
>      also register a regulator driver. Looking at the bq257xx driver,
>      this should be the preferred design?
>      
>   2. Other drivers add a custom `sysfs` attributes for BATFET control.
>      See for example rt9471 and bq24190. Is this the preferred approach?
>      Should we add a new power `sysfs` class ABI for this? (There is a
>      TODO left in the code for this.)
>      
>      I reckon it is quite common to have BATFET control for chargers,
>      i.e. being able to set them in "ship mode", "stand-by mode",
>      "shutdown mode" or "idle mode" (example values taken from the
>      `BATFET_CTRL` register field from datasheet [1])?
>      
>   3. This device has liquid detection and corrosion mitigation. I
>      couldn't find any existing device driver with this kind of
>      functionality. The datasheet [1] even mentions "patent pending",
>      although it refers to the USB type-C Specification 2.3... :)
>      
>      When liquid is detected in the charging port, an interrupt is
>      fired. Likewise, an interrupt can be fired when the port is dry
>      enough (according to some configured threshold value). My initial
>      thought was that maybe we can add "liquid detected" to the `health`
>      `sysfs` ABI? However, the question still remains though how one
>      should enable/disable and set threshold values for this (new power
>      class `sysfs` ABI or a custom one only for this driver)?
>
> [1] https://www.ti.com/lit/gpn/bq25630

[...]

Friendly ping incoming!