Re: [PATCH net-next v2 7/7] tipc: convert to getsockopt_iter
From: Breno Leitao
Date: Wed May 20 2026 - 12:45:13 EST
On Tue, May 19, 2026 at 04:08:39PM +0200, Paolo Abeni wrote:
> On 5/15/26 10:32 AM, Breno Leitao wrote:
> > @@ -3260,7 +3260,6 @@ static int tipc_getsockopt(struct socket *sock, int lvl, int opt,
> > break;
> > case TIPC_CONN_TIMEOUT:
> > value = tsk->conn_timeout;
> > - /* no need to set "res", since already 0 at this point */
>
> Since you have to repost, there is another obsoleted comment referring
> to "res" later on:
>
> return res; /* "get" failed */
>
> please strip it, too.
ack!
thanks for the review,
--breno