Re: [PATCH v14 00/32] perf tools: Add evsel to perf_sample

[Ian Rogers]

On Wed, May 20, 2026 at 3:32 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> On Wed, May 20, 2026 at 2:51 PM Arnaldo Carvalho de Melo
> <acme@xxxxxxxxxx> wrote:
> >
> >
> > Everything is at
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git tmp.perf-tools-next
> >
> > I also rebased my perf.data validation (that has some extra fixes, because... Sashiko):
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git perf-data-validation
> >
> > I think I addressed some of your review comments, if bored, take a look,
> > I'll submit as soon as I get what is in tmp.perf-tools-next moved to
> > perf-tools-next which I plan/hope to do later today, after the container
> > build tests finish.
>
> I'll look at the perf-data-validation branch. Would it be okay to post
> the patches to LKML so that we can get the Sashiko review on them?

In "perf session: Bound nr_cpus_avail and validate sample CPU" the
perf_session__deliver_event change appears to inline
evlist__parse_sample which seems unfortunate from a code reuse
point-of-view. The commit message calls this out but doesn't describe
the motivation for the change. Could we fix evlist__parse_sample?

Thanks,
Ian

> Thanks,
> Ian
>
> > - Arnaldo