Re: [PATCH v3 0/3] media: i2c: Add os02g10 camera sensor driver

[Elgin Perumbilly]

Hi Laurent,

>The following features are supported:
>- Manual exposure an gain control support.
>- vblank/hblank control support.
>- vflip/hflip control support
>- Test pattern control support.
>- Dynamic mode configuration (e.g. up to 1920 x 1080 @ 30 fps, SBGGR10)
>
>The driver is tested on mainline branch v7.0-rc2 on IMX8MP Debix Model a.
>
>v4l2-compliance 1.31.0-5387, 64 bits, 64-bit time_t
>v4l2-compliance SHA: 5508bc4301ac 2025-08-25 08:14:22
>
>Compliance test for device /dev/v4l-subdev3:
>
>Driver Info:
>        Driver version   : 7.0.0
>        Capabilities     : 0x00000000
>        Client Capabilities: 0x0000000000000002
>interval-uses-which
>Required ioctls:
>        test VIDIOC_SUDBEV_QUERYCAP: OK
>        test invalid ioctls: OK
>
>Allow for multiple opens:
>        test second /dev/v4l-subdev3 open: OK
>        test VIDIOC_SUBDEV_QUERYCAP: OK
>        test for unlimited opens: OK
>
>Debug ioctls:
>        test VIDIOC_LOG_STATUS: OK (Not Supported)
>
>Input ioctls:
>        test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
>        test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>        test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
>        test VIDIOC_ENUMAUDIO: OK (Not Supported)
>        test VIDIOC_G/S/ENUMINPUT: OK (Not Supported)
>        test VIDIOC_G/S_AUDIO: OK (Not Supported)
>        Inputs: 0 Audio Inputs: 0 Tuners: 0
>
>Output ioctls:
>        test VIDIOC_G/S_MODULATOR: OK (Not Supported)
>        test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>        test VIDIOC_ENUMAUDOUT: OK (Not Supported)
>        test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
>        test VIDIOC_G/S_AUDOUT: OK (Not Supported)
>        Outputs: 0 Audio Outputs: 0 Modulators: 0
>
>Input/Output configuration ioctls:
>        test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
>        test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
>        test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
>        test VIDIOC_G/S_EDID: OK (Not Supported)
>
>Control ioctls:
>        test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK
>        test VIDIOC_QUERYCTRL: OK
>        test VIDIOC_G/S_CTRL: OK
>        test VIDIOC_G/S/TRY_EXT_CTRLS: OK
>        test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
>        test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
>        Standard Controls: 12 Private Controls: 0
>
>Format ioctls:
>        test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK (Not Supported)
>        test VIDIOC_G/S_PARM: OK (Not Supported)
>        test VIDIOC_G_FBUF: OK (Not Supported)
>        test VIDIOC_G_FMT: OK (Not Supported)
>        test VIDIOC_TRY_FMT: OK (Not Supported)
>        test VIDIOC_S_FMT: OK (Not Supported)
>        test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
>        test Cropping: OK (Not Supported)
>        test Composing: OK (Not Supported)
>        test Scaling: OK (Not Supported)
>
>Codec ioctls:
>        test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
>        test VIDIOC_G_ENC_INDEX: OK (Not Supported)
>        test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
>
>Buffer ioctls:
>        test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK (Not Supported)
>        test CREATE_BUFS maximum buffers: OK
>        test VIDIOC_REMOVE_BUFS: OK
>        test VIDIOC_EXPBUF: OK (Not Supported)
>        test Requests: OK (Not Supported)
>        test blocking wait: OK (Not Supported)
>
>Total for device /dev/v4l-subdev3: 46, Succeeded: 46, Failed: 0, Warnings: 0
>
>V2 -> V3
>
>Patch 1/3:
>- Drop the fixed data-lanes property, as the sensor supports only a 2-lane MIPI interface.
>
>Patch 2/3:
>- Use regmap paging features for page selection.
>- Use sd instead of _sd.
>- Remove an extra blank line.
>- Remove hblank control, as it is not used to set hblank on this sensor.
>- Remove an unnecessary error check.
>- Reduce the scope of the ret variable in os02g10_set_pad_format().
>- Rely on the control value for link_freq_index.
>- Call os02g10_parse_endpoint() before initializing regulators, GPIOs, and the clock in probe().
>
>Add new Patch 3/3:
>- Add dynamic mode configuration instead of using a hardcoded specific mode, as suggested by Laurent.
>
>V1 -> V2
>
>patch 1/2:
>- Corrected $id to ovti,os02g10.yaml
>- Fixed data-lanes property structure to use proper items format
>
>patch 2/2:
>- Mode-specific register writes handled dynamically.
>- Moved page 2 registers into a dedicated page 2 block.
>- Used pm_runtime_get_if_active() in set_ctrls.
>- Resolved negative hblank issue.
>- Improved error messages in disable_stream.
>- Updated V4L2_SEL_TGT_CROP and V4L2_SEL_TGT_CROP_BOUNDS.
>- Added my name to the author list.

Could you please review our patch, when you have some time?

Best Regards,
Elgin