Re: [PATCH] iio: dac: ad5686: update of_match_table

[Rodrigo Alencar]

On 26/05/20 07:57PM, Alexander A. Klimov wrote:
> When AD5673R/AD5677R support was added, of_match_table wasn't updated,
> so these two devices couldn't be probed based on device tree contents
> until now. I fixed this.
> 
> Fixes: 477bd010c20e ("iio: dac: ad5686: Add support for AD5673R/AD5677R")
> Signed-off-by: Alexander A. Klimov <grandmaster@xxxxxxxxxxxx>
> ---
>  drivers/iio/dac/ad5696-i2c.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/dac/ad5696-i2c.c b/drivers/iio/dac/ad5696-i2c.c
> index d3327bca0e07..fb118a02f76e 100644
> --- a/drivers/iio/dac/ad5696-i2c.c
> +++ b/drivers/iio/dac/ad5696-i2c.c
> @@ -91,7 +91,9 @@ static const struct of_device_id ad5686_of_match[] = {
>  	{ .compatible = "adi,ad5337r" },
>  	{ .compatible = "adi,ad5338r" },
>  	{ .compatible = "adi,ad5671r" },
> +	{ .compatible = "adi,ad5673r" },
>  	{ .compatible = "adi,ad5675r" },
> +	{ .compatible = "adi,ad5677r" },
>  	{ .compatible = "adi,ad5691r" },
>  	{ .compatible = "adi,ad5692r" },
>  	{ .compatible = "adi,ad5693" },
> -- 
> 2.54.0
> 

I am aware of this, but it is going to conflict with:
https://lore.kernel.org/linux-iio/20260505-ad5686-fixes-v6-0-c2d5f7be32be@xxxxxxxxxx/

This is also to be handled by follow up work:
https://lore.kernel.org/all/20260422-ad5313r-iio-support-v1-1-ed7dca001d1b@xxxxxxxxxx/
https://lore.kernel.org/all/20260422-ad5313r-iio-support-v1-9-ed7dca001d1b@xxxxxxxxxx/

checkpatch would complain about this, once the dt-binding needs to come first.

-- 
Kind regards,

Rodrigo Alencar