Re: (subset) [PATCH 0/4] power: sys-off: fix Pixel C shutdown via MAX77620

[Diogo Ivo]

Hi Lee,

On 5/20/26 18:25, Lee Jones wrote:
> On Thu, 14 May 2026 16:47:18 +0200, Diogo Ivo wrote:
> > This series migrates PSCI and MAX77620 poweroff handling to the
> > sys-off framework and fixes shutdown on the Pixel C (Smaug).
> >
> > The first two patches replace legacy pm_power_off usage in the PSCI
> > and MAX77620 drivers with sys-off handlers. Besides aligning both
> > drivers with the modern poweroff infrastructure, this removes the
> > global callback dependency and allows multiple handlers to coexist
> > with explicit priorities.
> >
> > [...]
>
> Applied, thanks!

Thanks for applying the patches! Just a question and an observation:

 - I'm assuming you were ok with merging [2/4] despite the possible
   deadlock since this risk is already present in mainline in the same
   form so we're not actually making things worse, is that so?

 - The observation is that the comment about overriding PSCI is only
   true after (and if) a reworked [1/4] is actually merged.
   If it isn't then patch [3/4] is actually working around another handler
   in soc/tegra/pmc.c where a handler that only does work for the Nexus
   7 is actually registered at FIRMWARE level for all platforms that
   probe that driver (I will send out a patch shortly to only register
   the handler on the Nexus 7).

Best regards,
Diogo

> [2/4] mfd: max77620: convert poweroff support to sys-off API
>        commit: 1ada6d7f88063dd6fd92d74d0b803875b695fe01
> [3/4] mfd: max77620: override PSCI poweroff handler on Pixel C
>        commit: ea3f90bcc8524c6d514f6b8183cc202b79b082be
>
> --
> Lee Jones [李琼斯]