Re: [PATCH net-next v8 3/3] gve: implement PTP gettimex64
From: David Laight
Date: Thu May 21 2026 - 06:09:40 EST
On Wed, 20 May 2026 23:08:42 +0200
Thomas Gleixner <tglx@xxxxxxxxxx> wrote:
> On Thu, May 14 2026 at 22:58, Harshitha Ramamurthy wrote:
...
> > + do {
> > + *pre_cycles = get_cycles();
>
> This is a completely non-sensical hack. Why do you need get_cycles()
> here, which is a horrible and ill-defined interface that others are
> trying to get rid of?
ISTR that it has always returned 0 on some architectures.
-- David