Re: [PATCH 1/2] firmware: qcom: scm: add trace events for the SMC call interface
From: Konrad Dybcio
Date: Thu May 21 2026 - 08:10:16 EST
On 5/6/26 12:37 PM, Yuvaraj Ranganathan wrote:
> The SCM SMC call path is opaque at runtime. Stalls caused by firmware
> congestion, QCOM_SCM_WAITQ_SLEEP/RESUME cycles, and EBUSY retry loops
> are invisible without recompiling the kernel with temporary printk
> statements or attaching a hardware debugger.
[...]
> + TP_fast_assign(
> + __entry->wq_ctx = wq_ctx;
> + __entry->smc_call_ctx = smc_ctx;
nit: these tabs-before-assignments seem forced
otherwise I think this looks good
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad