Re: [PATCH v4 3/5] firmware: arm_ffa: Fix Endpoint Memory Access Descriptor offset calculation

From: Sudeep Holla

Date: Thu May 21 2026 - 09:05:49 EST


On Wed, May 20, 2026 at 08:49:46PM +0000, Mostafa Saleh wrote:
> From: Sebastian Ene <sebastianene@xxxxxxxxxx>
>
> Use the descriptor's `ep_mem_offset` to calculate the start of the endpoint
> memory access array and to comply with the FF-A spec instead of defaulting
> to `sizeof(struct ffa_mem_region)`.
> This requires moving `ffa_mem_region_additional_setup()` earlier in the setup
> flow.
> Also, add sanity checks to ensure the calculated descriptor offsets do not
> exceed `max_fragsize`.
>

Core change remains same as v3 except improved error checking, so my
review still applies.

Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxxxxx>

--
Regards,
Sudeep