Re: [PATCH v2 10/10] sched/eevdf: Move to a single runqueue

[Peter Zijlstra]

On Thu, May 21, 2026 at 12:31:17PM +0200, Peter Zijlstra wrote:

> Would it not be simpler to just move the update_entity_lag() call up a
> bit, like so?
> 
> ---
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -7999,6 +7999,9 @@ static bool __dequeue_task(struct rq *rq
>  
>  	clear_buddies(cfs_rq, se);
>  
> +	update_curr(cfs_rq);
> +	update_entity_lag(cfs_rq, se);
> +
>  	if (flags & DEQUEUE_DELAYED) {
>  		WARN_ON_ONCE(!se->sched_delayed);
>  	} else {
> @@ -8022,7 +8025,6 @@ static bool __dequeue_task(struct rq *rq
>  
>  	dequeue_hierarchy(p, flags);
>  
> -	update_entity_lag(cfs_rq, se);
>  	if (sched_feat(PLACE_REL_DEADLINE) && !task_sleep) {
>  		se->deadline -= se->vruntime;
>  		se->rel_deadline = 1;

FWIW, I pushed out a new queue:sched/flat with this on. I had to rebase
because of: 6d2051403d6c ("sched/fair: Update util_est after updating
util_avg during dequeue"), hopefully I didn't wreck that :/