Re: [PATCH net-next v3] net: napi: Skip last poll when arming gro timer in busy poll
From: Paolo Abeni
Date: Thu May 21 2026 - 10:34:16 EST
On 5/18/26 8:13 PM, Martin Karsten wrote:
> + } else {
> + /* All we really want here is to re-enable device interrupts. */
> + rc = napi->poll(napi, budget);
> + /* We can't gro_normal_list() here, because napi->poll() might
> + * have rearmed the napi (napi_complete_done()) in which case
> + * it could already be running on another CPU.
> + */
> + trace_napi_poll(napi, rc, budget);
> + netpoll_poll_unlock(have_poll_lock);
> + if (rc == budget) {
> + gro_normal_list(&napi->gro);
Not blocking, but I find the above slightly confusing after this
refactor. Perhaps it should be re-worded?
/P