Re: [PATCH] nfsd: fix posix_acl leak and ignored error in nfsd4_create_file

From: Chuck Lever

Date: Thu May 21 2026 - 15:39:05 EST


From: Chuck Lever <chuck.lever@xxxxxxxxxx>

On Thu, 21 May 2026 12:37:33 -0400, Jeff Layton wrote:
> nfsd4_create_file() has two bugs in its ACL handling:
>
> The return value of nfsd4_acl_to_attr() is silently discarded. When
> the NFSv4-to-POSIX ACL conversion fails (e.g., -EINVAL for
> unsupported ACE types), the file is created without any ACL and the
> client receives NFS4_OK. This violates RFC 7530/8881 which require
> the server to reject unsupported attributes on CREATE.
>
> [...]

Applied to nfsd-testing, thanks!

[1/1] nfsd: fix posix_acl leak and ignored error in nfsd4_create_file
commit: 15906201636c0850eff0e2e86791f24e007d4160

--
Chuck Lever <chuck.lever@xxxxxxxxxx>