Re: [PATCH v1 2/3] ACPI: button: Enable wakeup GPEs for ACPI buttons at probe time

From: Nick

Date: Thu May 21 2026 - 21:49:09 EST


Hello Rafael,


On Thu, May 21 2026 at 03:38:50 PM +02:00:00, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:

Link: https://lore.kernel.org/linux-acpi/E2OXET.4X5GTP37VTNC3@xxxxxxxx/ [1]
Fixes: 57c31e6d620f ("ACPI: scan: Use acpi_setup_gpe_for_wake() for buttons")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
Cc: 7.0+ <stable@xxxxxxxxxxxxxxx> # 7.0+
---

@Nick, I have reproduced the change of behavior introduced by commit
57c31e6d620f132dc on one of my systems, but not the function keys
regression because they are handled differently here. This patch
should restore the missing functionality on your machine, but I would
appreciate some testing feedback.

I have applied this patch series on top of today's mainline (8bc67e4db64aa727). It worked! My brightness keys and mute and lidswitch are back. That's great. Thank you! Learning how to bisect was a steep curve for me but everything after that has been a really easy experience. Thank you for knowing this subsystem deeply.

- Nick