Re: [PATCH] crypto: loongson - Select CRYPTO_RNG

[Eric Biggers]

On Fri, May 22, 2026 at 10:52:42AM +0800, Huacai Chen wrote:
> On Fri, May 22, 2026 at 10:26 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
> >
> > This driver registers a rng_alg, so it requires CRYPTO_RNG.
> >
> > Fixes: 766b2d724c8d ("crypto: loongson - add Loongson RNG driver support")
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202605201622.qWOiiZTV-lkp@xxxxxxxxx/
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> Reviewed-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> > ---
> >  drivers/crypto/loongson/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >

By the way, do any of the loongson people have any comment on what they
think the point of this driver is?  It's not registered with the actual
hwrng subsystem, but rather the pointless crypto_rng system which no one
uses.  So if it was intended to provide entropy for /dev/urandom etc.,
that isn't what it's doing.

Can we just delete this driver?

- Eric