Re: [PATCH v1 5/9] arm64: dts: agilex5: add SOCDK eMMC daughter board support

[Kathpalia, Tanmay]

[Re-sending in plain text due to HTML rejection by the mailing list.]

Hi Krzyztof,

Thanks for your feedback.

On 5/15/2026 2:07 PM, Krzysztof Kozlowski wrote:
> On Mon, May 11, 2026 at 01:21:27PM -0700, Tanmay Kathpalia wrote:
> > Add device tree support for the Agilex5 SOCDK board variant with
> > eMMC daughter card.
> >
> > Update the SoC dtsi with a fixed 1.8V regulator for eMMC I/O voltage.
> >
> > Add socfpga_agilex5_socdk_emmc.dts with eMMC controller configured for:
> > - 8-bit bus width
> > - Non-removable eMMC device
> > - High-speed, HS200, and HS400 modes at 1.8V
> > - 200MHz maximum frequency with SDHCI clock base capability override
> >
> > Signed-off-by: Tanmay Kathpalia <tanmay.kathpalia@xxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/intel/Makefile            |   1 +
> >   .../arm64/boot/dts/intel/socfpga_agilex5.dtsi |   8 ++
> >   .../dts/intel/socfpga_agilex5_socdk_emmc.dts  | 111 ++++++++++++++++++
> >   3 files changed, 120 insertions(+)
> >   create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_emmc.dts
> >
> > diff --git a/arch/arm64/boot/dts/intel/Makefile b/arch/arm64/boot/dts/intel/Makefile
> > index 33fcc55d0cb9..5bbbcfda1f48 100644
> > --- a/arch/arm64/boot/dts/intel/Makefile
> > +++ b/arch/arm64/boot/dts/intel/Makefile
> > @@ -8,5 +8,6 @@ dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_n6000.dtb \
> >   				socfpga_agilex5_socdk_013b.dtb \
> >   				socfpga_agilex5_socdk_modular.dtb \
> >   				socfpga_agilex5_socdk_nand.dtb \
> > +				socfpga_agilex5_socdk_emmc.dtb \
> >   				socfpga_n5x_socdk.dtb
> >   dtb-$(CONFIG_ARCH_KEEMBAY) += keembay-evm.dtb
> > diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > index 7e080f13166f..feb4ccb317a7 100644
> > --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
> > @@ -317,6 +317,14 @@ sd_io_1v8_reg: regulator-1p8v {
> >   					<3300000 0x0>;
> >   		};
> >   
> > +		emmc_io_1v8_reg: regulator-fixed-1p8v {
> How is this property of a SoC? How SoC itself has a fixed regulator for
> EMMC? Really?
>
> Best regards,
> Krzysztof

Apologies, you are absolutely right.

The emmc_io_1v8_reg regulator is a fixed 1.8v rail on the eMMC
daughter card, not a property of the SoC silicon.

In v2 this will be fixed:
emmc_io_1v8_reg will be moved to the root level of
socfpga_agilex5_socdk_emmc.dts where it correctly describes
board-level hardware.

Regards,
Tanmay