Re: [PATCH net-next] net: e100: remove redundant static variable initializations
From: David Laight
Date: Fri May 22 2026 - 04:22:07 EST
On Fri, 22 May 2026 12:22:30 +0530
Ashwin Gundarapu <linuxuser509@xxxxxxxxxxx> wrote:
> From: Ashwin Gundarapu <linuxuser509@xxxxxxxxxxx>
> Date: Fri, 22 May 2026 12:20:23 +0530
> Subject: [PATCH] net: e100: remove redundant static variable initializations
>
> Remove '= 0' from static variables eeprom_bad_csum_allow and use_io.
> Static variables are zero-initialized by default.
>
> Found by checkpatch.pl
Not worth the churn for existing code.
-- David
>
> Signed-off-by: Ashwin Gundarapu <linuxuser509@xxxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/e100.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
> index bfacf877ca40..bdddd4315cbb 100644
> --- a/drivers/net/ethernet/intel/e100.c
> +++ b/drivers/net/ethernet/intel/e100.c
> @@ -167,8 +167,8 @@ MODULE_FIRMWARE(FIRMWARE_D101S);
> MODULE_FIRMWARE(FIRMWARE_D102E);
>
> static int debug = 3;
> -static int eeprom_bad_csum_allow = 0;
> -static int use_io = 0;
> +static int eeprom_bad_csum_allow;
> +static int use_io;
> module_param(debug, int, 0);
> module_param(eeprom_bad_csum_allow, int, 0444);
> module_param(use_io, int, 0444);
> --
> 2.43.0
>