Re: [PATCH v2] media: i2c: alvium: Fix: correct typo in alvium_set_ctrl_auto_exposure
From: Sakari Ailus
Date: Fri May 22 2026 - 06:45:30 EST
Hi Martin,
Considering the subject, I think it looks like more than a typo: the wrong
register gets written here before the patch. I think it'd be reasonable to
say that.
On Tue, May 05, 2026 at 09:26:52AM +0200, Martin Hecht wrote:
> write value for auto-exposure into register REG_BCRM_EXPOSURE_AUTO_RW
> instead of wrong register REG_BCRM_WHITE_BALANCE_AUTO_RW.
The sententence should begin with a capital letter.
>
> Fixes: 0a7af872915e ("media: i2c: Add support for alvium camera")
> Signed-off-by: Martin Hecht <mhecht73@xxxxxxxxx>
Cc: stable..., please.
> ---
> drivers/media/i2c/alvium-csi2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/alvium-csi2.c b/drivers/media/i2c/alvium-csi2.c
> index 955b7072a560..b62b45a4f2fc 100644
> --- a/drivers/media/i2c/alvium-csi2.c
> +++ b/drivers/media/i2c/alvium-csi2.c
> @@ -1290,7 +1290,7 @@ static int alvium_set_ctrl_auto_exposure(struct alvium_dev *alvium, bool on)
> struct device *dev = &alvium->i2c_client->dev;
> int ret;
>
> - ret = alvium_write_hshake(alvium, REG_BCRM_WHITE_BALANCE_AUTO_RW,
> + ret = alvium_write_hshake(alvium, REG_BCRM_EXPOSURE_AUTO_RW,
> on ? 0x02 : 0x00);
> if (ret) {
> dev_err(dev, "Fail to set autoexposure reg\n");
--
Kind regards,
Sakari Ailus