Re: [PATCH v3] drm/loongson: Use managed KMS polling

[Icenowy Zheng]

在 2026-05-13三的 15:57 +0900，Myeonghun Pak写道：
> lsdc_pci_probe() initializes KMS polling before setting up vblank
> support,
> requesting the IRQ and registering the DRM device. If any of those
> later
> steps fails, probe returns without finalizing polling. The driver
> also
> never finalizes polling on regular removal.
> 
> Use drmm_kms_helper_poll_init() so polling is tied to the DRM device
> lifetime and automatically finalized on probe failure and device
> removal.
> 
> This issue was identified during our ongoing static-analysis research
> while
> reviewing kernel code.
> 
> Fixes: f39db26c5428 ("drm: Add kms driver for loongson display
> controller")
> Cc: stable@xxxxxxxxxxxxxxx
> Co-developed-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Ijae Kim <ae878000@xxxxxxxxx>
> Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Acked-by: Jianmin Lv <lvjianmin@xxxxxxxxxxx>
> Reviewed-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
> Signed-off-by: Myeonghun Pak <mhun512@xxxxxxxxx>

Reviewed-by: Icenowy Zheng <zhengxingda@xxxxxxxxxxx>

Thanks,
Icenowy

> ---
> Changes in v3:
> - Capitalize the subject as suggested by Huacai Chen.
> - Add Reviewed-by and Acked-by tags.
> 
> Changes in v2:
> - Switch to drmm_kms_helper_poll_init() as suggested by Icenowy Zheng
>   and Thomas Zimmermann instead of adding manual cleanup paths.