Re: [PATCH] hwrng: core - Do not read data during PM sleep transition

From: Herbert Xu

Date: Fri May 22 2026 - 08:08:34 EST


On Wed, May 13, 2026 at 11:27:37AM +0200, Thomas Richard (TI) wrote:
>
> @@ -538,8 +539,9 @@ static int hwrng_fillfn(void *unused)
> }
>
> mutex_lock(&reading_mutex);
> - rc = rng_get_data(rng, rng_fillbuf,
> - rng_buffer_size(), 1);
> + if (!pm_sleep_transition_in_progress())
> + rc = rng_get_data(rng, rng_fillbuf,
> + rng_buffer_size(), 1);

Isn't this going to cause rc to be used uninitialised?

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt