Re: [PATCH 1/2] crypto: omap-des - add COMPILE_TEST and fix CONFIG_OF=n build

From: Herbert Xu

Date: Fri May 22 2026 - 09:04:19 EST


On Sun, May 17, 2026 at 12:34:14PM +0200, Thorsten Blum wrote:
> CRYPTO_DEV_OMAP_DES only depends on ARCH_OMAP2PLUS, which is ARM-only
> and selects OF via ARM's USE_OF, making any non-OF code unreachable.
>
> Add COMPILE_TEST so the driver can be built with CONFIG_OF=n, making the
> non-OF code reachable.
>
> Fix the resulting non-OF build failures:
>
> - omap_des_irq() was defined inside a CONFIG_OF block, but is referenced
> unconditionally from omap_des_probe(). Move the CONFIG_OF guard so it
> only covers omap_des_get_of().
>
> - The non-OF omap_des_get_of() stub took a struct device *, while
> omap_des_probe() passes a struct platform_device *. Make the stub
> prototype match the OF implementation and the caller.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> ---
> drivers/crypto/Kconfig | 4 ++--
> drivers/crypto/omap-des.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt