Re: [PATCH v3 7/7] iio: light: opt3001: add comment to mutex

[Joshua Crofts]

On Fri, 22 May 2026 at 16:13, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> On Thu, 21 May 2026 11:55:44 +0200
> Joshua Crofts via B4 Relay <devnull+joshua.crofts1.gmail.com@xxxxxxxxxx> wrote:
>
> > From: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> >
> > Add comment to mutex per checkpatch.pl report.
> >
> > No functional change.
> >
> > Reviewed-by: Maxwell Doose <m32285159@xxxxxxxxx>
> > Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> > ---
> >  drivers/iio/light/opt3001.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/light/opt3001.c b/drivers/iio/light/opt3001.c
> > index ac1c7ba5679867f6b814894680e317615f2e373b..9d24d7a23ef00d160fdae737b6ea1943576a3fcf 100644
> > --- a/drivers/iio/light/opt3001.c
> > +++ b/drivers/iio/light/opt3001.c
> > @@ -103,6 +103,7 @@ struct opt3001_chip_info {
> >  struct opt3001 {
> >       struct i2c_client       *client;
> >
> > +     /* Mutex for ensuring one executed command at a time */
>
> The device uses a 'register' type control scheme rather than
> command based. So I'm not sure what intended meaning of this is.
> I'd say something like

Of course, no clue how I got the idea of it being command based.
Must've mixed up the files...

--
Kind regards

CJD