Re: [PATCH v5 03/10] drm/msm/dp: Read DPCD and sink count in bridge detect()

From: Dmitry Baryshkov

Date: Fri May 22 2026 - 11:29:55 EST


On Fri, May 22, 2026 at 01:30:54PM +0200, Konrad Dybcio wrote:
> On 3/14/26 2:09 AM, Dmitry Baryshkov wrote:
> > From: Jessica Zhang <jesszhan0024@xxxxxxxxx>
> >
> > Instead of relying on the link_ready flag to specify if DP is connected,
> > read the DPCD bits and get the sink count to accurately detect if DP is
> > connected.
> >
> > Signed-off-by: Jessica Zhang <jessica.zhang@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> > ---
>
> There's still some trailing style/documentation feedback here from v3

I'll correct most of the feedback from both you and Bjorn. I'll leave pm
calls as is, without using ACQUIRE macros. I will think about using them
for the whole driver rather than just a single function.

>
> Konrad

--
With best wishes
Dmitry