Re: [PATCH v3] libbpf: fix UAF in strset__add_str()
From: Carlos Llamas
Date: Fri May 22 2026 - 14:50:30 EST
On Fri, May 22, 2026 at 11:35:58AM -0700, Andrii Nakryiko wrote:
> >
> > sashiko suggests to use uintptr_t for this detection to avoid
> > undefined behavior, let's do that then)?
> >
> > but other than that and a nit below, looks good, thanks!
> >
> > pw-bot: cr
>
> Ping. Carlos, are you planning to send a follow up?
Hey Andrii sorry about the delay I got caught up with something else
here. I'll send a new version in a bit with the uintptr_t casting and
your suggestion. I would just say that it is a bit unfortunate that
we'll have to clutter the code with this kind of parsing to avoid the
compiler behavior that was mentioned. :(
Thanks,
Carlos Llamas