Re: [PATCH v4 18/20] gpu: nova-core: vbios: drop unused image wrappers

[John Hubbard]

On 5/18/26 7:55 PM, Eliot Courtney wrote:
> These are unused currently, and it is probably sufficient to just check
> the type of BIOS image in the future.
> 
> Signed-off-by: Eliot Courtney <ecourtney@xxxxxxxxxx>
> ---
>  drivers/gpu/nova-core/vbios.rs | 12 ------------
>  1 file changed, 12 deletions(-)

Reviewed-by: John Hubbard <jhubbard@xxxxxxxxxx>

thanks,
-- 
John Hubbard

> 
> diff --git a/drivers/gpu/nova-core/vbios.rs b/drivers/gpu/nova-core/vbios.rs
> index 1dca7933fac5..ad571b39400d 100644
> --- a/drivers/gpu/nova-core/vbios.rs
> +++ b/drivers/gpu/nova-core/vbios.rs
> @@ -669,18 +669,6 @@ struct PciAtBiosImage {
>      bit_offset: usize,
>  }
>  
> -#[expect(dead_code)]
> -struct EfiBiosImage {
> -    base: BiosImage,
> -    // EFI-specific fields can be added here in the future.
> -}
> -
> -#[expect(dead_code)]
> -struct NbsiBiosImage {
> -    base: BiosImage,
> -    // NBSI-specific fields can be added here in the future.
> -}
> -
>  /// The [`FwSecBiosImage`] structure contains the PMU table and the Falcon Ucode.
>  ///
>  /// The PMU table contains voltage/frequency tables as well as a pointer to the Falcon Ucode.
>