Re: [PATCH 0/7 v2] mm/memcontrol, page_counter: move stock from mem_cgroup to page_counter
From: Andrew Morton
Date: Sat May 23 2026 - 00:00:46 EST
On Fri, 22 May 2026 19:50:50 -0700 Joshua Hahn <joshua.hahnjy@xxxxxxxxx> wrote:
> On Fri, 22 May 2026 15:06:18 -0700 Joshua Hahn <joshua.hahnjy@xxxxxxxxx> wrote:
>
> > Memcg currently keeps a "stock" of 64 pages per-cpu to cache pre-charged
> > allocations, allowing small allocations to avoid walking the expensive
> > mem_cgroup hierarchy traversal and atomic operations on each charge.
> > This design introduces a fastpath, but there is room for improvement:
>
> This iteration was developed and tested on top of mm-stable.
> I'm seeing now that Sashiko cannot apply this patch, and I think it expects
> it to have been built on top of mm-new.
>
> Reviewers -- would it make sense to rebase this on top of mm-new and
> re-send this as a v3, or should I wait for feedback on this cycle
> before sending out a new version?
>
> In any case, this could have been avoided if I just developed on top of
> mm-new. I'll be mindful to do that in the future.
Sashiko does attempt various branches, including mm-stable so I'm not
sure what went wrong here.
It's a bit of a crapshoot at this time, as mm-new is still growing like
a weed (19 patches yesterday, 24 so far today). Slowing way down soon!
I'll be pushing mm-new later this evening and after that it shouldn't change
much for several days because we all take weekends off, don't we?
Convention appears to say "wait a week before resending" but IMO
there's value in parallelizing Sashiko review with human review. And
it's understandable if some humans aren't very motivated to review
until the AI thing has had a shot at it, because that might result in
alterations. So I'd say that a resend-for-Sashiko is appropriate.