Re: [PATCH] staging: rtl8723bs: remove unnecessary boolean comparisons in rtw_recv.c

From: Dan Carpenter

Date: Sat May 23 2026 - 06:23:23 EST


On Sat, May 23, 2026 at 12:30:20PM +0530, Ashwin Gundarapu wrote:
> @@ -1841,8 +1841,7 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un
> /* Duplicate entry is found!! Do not insert current entry. */
> /* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */
> return false;
> - else
> - break;
> + break;
>
> }

This is a bug. You have to think about what checkpatch says instead of
following it blindly. Also it's unrelated to the patch description.

regards,
dan carpenter