Re: [PATCH v2] dt-bindings: clock: via,vt8500: Convert to DT Schema

From: Uday Kiran

Date: Sat May 23 2026 - 13:45:44 EST


On Fri, May 22, 2026 at 12:12 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> > +
> > + plla: clock@200 {
> > + compatible = "wm,wm8650-pll-clock";
> > + reg = <0x200 0x04>;
> > + clocks = <&ref25>;
> > + #clock-cells = <0>;
> > + };
> > +
> > + clksdhc: clock {
>
> Entire binding is for part of other device, so where is the rest? This
> should not be done separately from the parent. And then example goes
> only to one place.

Thanks for the review Krzysztof.

And sorry, I initially converted the legacy clock/vt8500.txt binding directly to
YAML and missed that the clock nodes are actually child nodes of the PMC
device, which already has a separate binding documented in:

Documentation/devicetree/bindings/arm/vt8500/via,vt8500-pmc.txt

I'll rework this by splitting the conversion into two schemas:

via,vt8500-pmc.yaml for the PMC device itself
via,vt8500-clock.yaml for the clocks child node and the PLL/device clock child
bindings

The clock binding example will retain the PMC hierarchy context, but the PMC
properties themselves will be described in the PMC schema instead of
duplicating them in the clock binding.

Regards,
Udaya Kiran Challa