Re: [PATCH v5 08/10] drm/msm/dp: Add sink_count to debug logs

[Dmitry Baryshkov]

On Fri, May 22, 2026 at 01:40:36PM +0200, Konrad Dybcio wrote:
> On 3/14/26 2:09 AM, Dmitry Baryshkov wrote:
> > From: Jessica Zhang <jesszhan0024@xxxxxxxxx>
> > 
> > Add sink count to the debug logs for [un]plug and HPD IRQ handling.
> > 
> > Signed-off-by: Jessica Zhang <jessica.zhang@xxxxxxxxxxxxxxxx>
> > [DB: dropped link_ready handling]
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/msm/dp/dp_display.c | 30 ++++++++++++++++++------------
> >  1 file changed, 18 insertions(+), 12 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> > index d61a8ddd30a8..b4deeea0ec59 100644
> > --- a/drivers/gpu/drm/msm/dp/dp_display.c
> > +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> > @@ -388,8 +388,9 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp)
> >  	int ret;
> >  	struct platform_device *pdev = dp->msm_dp_display.pdev;
> >  
> > -	drm_dbg_dp(dp->drm_dev, "Before, type=%d\n",
> > -			dp->msm_dp_display.connector_type);
> > +	drm_dbg_dp(dp->drm_dev, "Before, type=%d sink_count=%d\n",
> 
> dp->link->sink_count is an u8 (perhaps over-eagerly? 'int' seems to
> be fine for "amount of things") and the struct gets padded anyway as
> of right now

i915 also uses u8 for sink_count. I think we can sort that out later.

-- 
With best wishes
Dmitry