Re: [PATCH 4/4] nfsd: fix ino_t format specifier in nfsd_handle_dir_event tracepoint

From: Jeff Layton

Date: Sun May 24 2026 - 08:12:54 EST


On Sat, 2026-05-23 at 12:17 -0400, Jeff Layton wrote:
> inode->i_ino is now a u64. Use the same size for the tracepoint.
>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
> fs/nfsd/trace.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h
> index 3d0f0bd30d90..1d5d11f914f2 100644
> --- a/fs/nfsd/trace.h
> +++ b/fs/nfsd/trace.h
> @@ -1384,7 +1384,7 @@ TRACE_EVENT(nfsd_handle_dir_event,
> TP_STRUCT__entry(
> __field(u32, mask)
> __field(dev_t, s_dev)
> - __field(ino_t, i_ino)
> + __field(ino_t, u64)

My apologies. This should read:

__field(u64, i_ino)

I had the fix in my tree and forgot to commit it before sending. Would
you like me to resend this one, or do you just want to fix it up?

> __string_len(name, name ? name->name : NULL,
> name ? name->len : 0)
> ),
> @@ -1394,7 +1394,7 @@ TRACE_EVENT(nfsd_handle_dir_event,
> __entry->i_ino = dir ? dir->i_ino : 0;
> __assign_str(name);
> ),
> - TP_printk("inode=0x%x:0x%x:0x%lx mask=%s name=%s",
> + TP_printk("inode=0x%x:0x%x:0x%llx mask=%s name=%s",
> MAJOR(__entry->s_dev), MINOR(__entry->s_dev),
> __entry->i_ino, show_fsnotify_mask(__entry->mask),
> __get_str(name))

--
Jeff Layton <jlayton@xxxxxxxxxx>