Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver

[Demi Marie Obenour]

On 5/24/26 16:29, Krzysztof Kozlowski wrote:
> On 24/05/2026 22:12, Demi Marie Obenour wrote:
>> On 5/24/26 12:42, Dmitry Baryshkov wrote:
>>> On Sat, May 23, 2026 at 03:03:56PM -0400, Demi Marie Obenour via B4 Relay wrote:
>>>> From: Demi Marie Obenour <demiobenour@xxxxxxxxx>
>>>>
>>>> It's slower than the generic C code and causes problems.
>>>
>>> Which problems?
>>
>> See https://lore.kernel.org/all/20260522024912.GC5937@quark/.
> 
> Your commit is still incomplete and other people's opinion is poor
> reason. If you do not know what to write, ask that person to make
> necessary changes.
> 
> Not mentioning that removing driver is not even necessary to achieve the
> goal Eric was mentioning and if I understood correctly: you are removing
> even the pieces Eric found useful.
> 
>>
>> Also, if there are no systems in which the QCE driver is actually
>> the highest priority, then unless someone adjusts priorities manually
>> it's unused code.
> 
> That's not a reason to remove a driver.
> 
> 
>>
>>> Also in the security world faster and safer are two orthogonal axis with
>>> very limited correlation.
>>
>> If by "safer" you mean protection against physical side-channel
>> attacks, then my understanding is that all operations on secret keys
>> need to be masked.  This includes copying and storage.
>>
>> Linux only supports this for protected keys, and even then sometimes
>> uses the kernel's own RNG for key generation.  There is no support
>> for using the QCE for protected keys.
>>
>> Linux does support using hardware-wrapped keys with inline crypto
>> engines, which are what are actually used on Android.
> 
> Patches are discussed for some time, did you miss that?
> 
> Best regards,
> Krzysztof

Thanks for the useful explanation.  I'll remove this patch from my
tree and won't resend it.
-- 
Sincerely,
Demi Marie Obenour (she/her/hers)

Attachment: OpenPGP_0xB288B55FFF9C22C1.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature