[PATCH net 0/2] net: pse-pd: fix use-after-free of PI array on controller teardown
From: Carlo Szelinsky
Date: Sun May 24 2026 - 18:33:57 EST
Two pre-existing use-after-frees in the PSE core teardown path surfaced
during review of the v5 poll/LED series: the IRQ-vs-pse_release_pis()
ordering was raised as an open question in the v5 cover, and the
regulator-disable UAF was spotted during Jakub's review of the LED
changes. They are independent of the poll/LED feature work, so as
suggested on the list they are sent here to net on their own.
Both are reached on controller unregister / driver unbind:
Patch 1: pse_controller_unregister() frees the PI array via
pse_release_pis() before disabling the IRQ, so a threaded pse_isr()
firing in that window walks the freed pcdev->pi[].
Patch 2: the PI regulators are devm-registered inside
pse_controller_register(), so on unbind devres tears the controller
down (freeing pcdev->pi) before the regulators. A deferred disable
flushed during regulator_unregister() then dereferences the freed PI
array in pse_pi_disable().
Both carry the same Fixes: tag (ffef61d6d273). The v6 poll/LED series
will be posted to net-next once these land and net-next has merged
them.
Link: https://lore.kernel.org/all/20260429213224.1747410-1-github@xxxxxxxxxxxx/
Carlo Szelinsky (2):
net: pse-pd: disable IRQ before freeing PI data in unregister
net: pse-pd: guard against freed PI data on regulator disable
drivers/net/pse-pd/pse_core.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
--
2.43.0