Re: [f2fs-dev] [PATCH v2] f2fs: another way to set large folio by remembering inode number
From: Christoph Hellwig
Date: Mon May 25 2026 - 01:37:15 EST
On Fri, May 22, 2026 at 03:32:39AM +0000, Jaegeuk Kim wrote:
> I went this route because Android heavily restricts ioctl() permissions
> and we needed broader access for this to work within the framework. It’s
> definitely a pragmatic choice just to get it running in production.
That is not a good reason.
> If ioctl() is a right way for upstream, I'm happy to change this patch. By
> the way, I really don't understand why all the messages are so offensive,
> even without trying to understand the problem or guiding right directions.
The right way is to:
1) Talk to the relevant subsystems (MM and fsdevel), and if it affects
userspace that linux-api list and actually explain your use case.
2) And then actually listen to feedback. f2fs just keeps piling these
ABI hacks on without any review, and it is causing real problems.